[READY] Print a message equivalent to that printed by waitress.serve

[puremourning]

#282 breaks emacs-ycmd as it parses the standard output to get the port that ycmd is listening on.

While it probably makes sense for emacs-ycmd to specify the port, this is a regression so we re-introduce the output equivalent to waitress.serve

---

This change is

[puremourning]

cc @ptrv

[vheon]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[micbou]

I was wondering why this message was not appearing anymore but didn't look further. I should have.

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

ycmd/main.py, line 188 [r1] (raw file):

  print( 'serving on http://{0}:{1}'.format(
    handlers.wsgi_server.effective_host,
    handlers.wsgi_server.effective_port ) )

I would move this to the StoppableWSGIServer class because it depends on waitress internals.

---

Comments from Reviewable

[codecov-io]

Current coverage is 92.69% (diff: 100%)

Merging #555 into master will increase coverage by <.01%

@@             master       #555   diff @@
==========================================
  Files            41         41          
  Lines          3778       3779     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3502       3503     +1   
  Misses          276        276          
  Partials          0          0          

Powered by Codecov. Last update 8b2f78a...cd7577d

[ptrv]

Thanks for bringing back the old behavior. We probably need to change the way emacs-ycmd starts the server and how it checks for the port (probably specifying the port when starting the server) but that would need more effort to change compared to just adapt the new shutdown process.

Thanks again for your work!

[puremourning]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

ycmd/main.py, line 188 [r1] (raw file):

Previously, micbou wrote…

I would move this to the StoppableWSGIServer class because it depends on waitress internals.

Done.

You're quite right.

---

Comments from Reviewable

[micbou]

@homu r+

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[homu]

📌 Commit ea9c80c has been approved by micbou

[homu]

⌛ Testing commit ea9c80c with merge 2daaa5b...

[homu]

☀️ Test successful - status