Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Add inlay hints tests #1739

Merged
merged 1 commit into from Apr 1, 2024
Merged

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Apr 1, 2024

Just a few basic tests.


This change is Reviewable

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 LGTMs obtained

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #1739 (a05ad3d) into master (743b729) will increase coverage by 0.34%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
+ Coverage   95.49%   95.84%   +0.34%     
==========================================
  Files          84       84              
  Lines        8318     8318              
  Branches      163      163              
==========================================
+ Hits         7943     7972      +29     
+ Misses        325      296      -29     
  Partials       50       50              

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Apr 1, 2024
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit da9c643 into ycm-core:master Apr 1, 2024
16 of 18 checks passed
@bstaletic bstaletic deleted the inlay_hints_tests branch April 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants