Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Implement LSP type/call hierarchies as actual hierarchies #1733

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Feb 11, 2024

This is the implementation of the server side changes needed to have useful support for LSP call/type hierarchies.
While the clien side changes deserve more attention, the server side should be fine to review and merge.

What's definitely missing are tests and API documentation.
On top of that, what do we want to do with the old GoToCollers/GoToCallees? I see three options:

  • Remove them completely, which might break some users, but the new alternative should be better.
  • Make them an alias for the new subcommands. This option wouldn't break users, but would break clients who would not adapt.
  • Do nothing and maintain the old API forever, like with have done with other things in the past.

This change is Reviewable

@puremourning
Copy link
Member

I need to schedule some time to play with this poc

@bstaletic bstaletic force-pushed the hierarchies branch 2 times, most recently from e663097 to dcab4b9 Compare May 14, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants