Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use latest Omnisharp-rosyln for .NET 6 support #1659

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mispencer
Copy link
Contributor

@mispencer mispencer commented Sep 12, 2022

The version of Omnisharp-rosyln doesn't support .NET 6. To provide this support, we upgrade to the latest Omnisharp-roslyn, and use the .NET 6 build of it.

Issues not necessarily resolvable:

  • This requires the users to have .NET 6 SDK installed on this machines
  • There appears to be no build of Linux x86 to use

Current issues to be resolved:

  • The windows x86 tests are failing
  • This doesn't appear to be compatible with .NET framework in non-Windows OSs
  • This is a beta release of Omnisharp-roslyn

This change is Reviewable

@mispencer mispencer marked this pull request as draft September 12, 2022 16:46
@puremourning
Copy link
Member

Thanks! Sorry for the delay - I've been on vacation and had covid.

Worth me looking at it now, or wait for the issues to be resolved?

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the changes look ok to me

Reviewable status: 0 of 2 LGTMs obtained

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @mispencer)

@RA-Kooi
Copy link

RA-Kooi commented Nov 3, 2022

This doesn't appear to be compatible with .NET framework in non-Windows OSs

I can confirm the .NET 6.0 (non-mono) version works for me on Arch Linux and Gentoo Linux.

This is a beta release of Omnisharp-roslyn

This is a while ago, I think we can assume it's in stable now?

@mispencer
Copy link
Contributor Author

That is correct. There is a stable release now.

@bstaletic
Copy link
Collaborator

@mispencer I have rebased this branch locally and pushed to my fork. However, I can't figure out what omnisharp is doing, as diagnostics and completion all seem pretty off from what ycmd expects in its tests.

Here's a link https://github.com/bstaletic/ycmd/tree/OmnisharpLatest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants