Make switching to semantic completer work after select ID completer candidate #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4208 +/- ##
==========================================
+ Coverage 89.70% 89.79% +0.09%
==========================================
Files 34 34
Lines 4419 4420 +1
==========================================
+ Hits 3964 3969 +5
+ Misses 455 451 -4 |
puremourning
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
bstaletic
force-pushed
the
id_semantic_switch_mess
branch
from
ab3003f
to
430ae85
Compare
…andidate To play nice with some other plugins, we only trigger completion if the cursor has not moved between making a request and displaying the results. Previous oversight led to being unable to switch to semantic completion after selecting an identifier completer candidate that changes the cursor position. The fix is to update the last cursor position from which the completion request was made when the user hits <C-Space>
|
Fixed the tests. |
puremourning
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
[Please explain in detail why the changes in this PR are needed.]
This change is