Add the ability to pass popup_params when creating a custom ycm_hover

[eliasdaler]

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

• I have read and understood YCM's CONTRIBUTING document.
• I have read and understood YCM's CODE_OF_CONDUCT document.
• I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.
• I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.

Why this change is necessary and useful

This PR adds the ability to pass popup_params to a custom ycm_hover like this:

autocmd FileType c,cpp let b:ycm_hover = {
  \ 'command': 'GetDoc',
  \ 'syntax': &filetype,
  \ 'popup_params': {
      \ 'drag': 1,
      \ 'maxwidth': 80,
      \ 'resize': 1,
      \ 'border': [],
      \ 'borderchars': ['─', '│', '─', '│', '┌', '┐', '┘', '└'],
  \   },
  \ }
augroup END

This allows users to customize the popup window by adding maximum width, borders and other behaviour:

popup2.mp4

---

This change is 

[puremourning]

NICE! thanks.

LGTM with a few nits.

Reviewable status: 0 of 2 LGTMs obtained (waiting on @eliasdaler)

---

autoload/youcompleteme.vim line 1653 at r1 (raw file):

    endif

    let s:popup_params = {

I don't think this needs to be a script-local variable. Function-local is fine (let popup_params = ...).

---

autoload/youcompleteme.vim line 1664 at r1 (raw file):

    if has_key( b:ycm_hover, 'popup_params' )
      let s:popup_params = extend( copy( s:popup_params ), b:ycm_hover.popup_params )

looks > 80 chars

---

doc/youcompleteme.txt line 3280 at r1 (raw file):

- 'syntax': The syntax to use (as in 'set syntax=') in the popup window for
  highlighting.
- 'popup_params': The params passed to a popup window which gets opened.

need to make this change in README.md rather than here. This file is generated from README.md

[puremourning]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @eliasdaler)

[codecov]

Codecov Report

Merging #4137 (0378f61) into master (aaebb55) will decrease coverage by 10.19%.
The diff coverage is 100.00%.

❗ Current head 0378f61 differs from pull request most recent head a4a869c. Consider uploading reports for the commit a4a869c to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4137       +/-   ##
===========================================
- Coverage   84.07%   73.88%   -10.19%     
===========================================
  Files          34       34               
  Lines        4483     4484        +1     
===========================================
- Hits         3769     3313      -456     
- Misses        714     1171      +457     

[eliasdaler]

need to make this change in README.md rather than here. This file is generated from README.md
Done.

I also noticed that YCM's docs refer to other docs by saying "see :help <something>" and not by using tags like |something| which allow you to jump to the tag directly when reading the docs.

Is this the limitation of generator that people are okay with, or is this |something| syntax avoided on purpose?

[puremourning]

It's a limitation of the converter.

[puremourning]

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @eliasdaler)

---

autoload/youcompleteme.vim line 1655 at r3 (raw file):

    let popup_params = {
          \ 'col': col,
          \ 'wrap': 1,

this change seems wrong?

[eliasdaler]

Indeed. Fixed.

[puremourning]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @eliasdaler)

[puremourning]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @eliasdaler)

[puremourning]

Thanks

[mergify]

Thanks for sending a PR!