New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Add error messages when ycmd crashed #2142
Conversation
This shit is the bee's knees! :D Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions. python/ycm/youcompleteme.py, line 93 [r1] (raw file): python/ycm/youcompleteme.py, line 188 [r1] (raw file): 👏 👏 👏 Comments from Reviewable |
7bb7857
to
3ed71b8
Compare
This PR now uses the symbolic names for exit statuses defined in ycm-core/ycmd#467. I made some simplifications too. It is really a shame that there is no switch blocks in Python. I find them neater than Reviewed 3 of 4 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4. Comments from Reviewable |
I hear that dictionaries are the new switch statement. More pythonic madness. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 3 of 4 files at r1, 1 of 1 files at r4. Comments from Reviewable |
So to recap the potential benefit of this PR:
Reviewed 3 of 4 files at r1, 1 of 1 files at r4. Comments from Reviewable |
I have a strange problem with reviewable: if I trigger homu from here I get an error and I cannot publish the message 😕 Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
I encountered some network issues with reviewable this evening but not this kind of bug. Anyway, don't trigger homu until ycm-core/ycmd#467 is merged. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Display an error message to the user depending on the status code returned by the ycmd server. Remove ycm_core checks in plugin/youcompleteme.vim. These checks are now done by the ycmd server. Do not start a separate process to check the core version but rely on ycmd returning a specific exit code. This slightly improves the Vim startup time.
Updated to latest ycmd so that it includes PR ycm-core/ycmd#467. Changing the tag to READY. Reviewed 2 of 2 files at r5, 1 of 1 files at r6. Comments from Reviewable |
@micbou I believe you have all the approval you need. If is all set I think you can fire up Reviewed 2 of 2 files at r5, 1 of 1 files at r6. Comments from Reviewable |
@homu r=vheon Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
📌 Commit d2beb20 has been approved by |
[READY] Add error messages when ycmd crashed See PR ycm-core/ycmd#467. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2142) <!-- Reviewable:end -->
⚡ Test exempted - status |
See PR ycm-core/ycmd#467.
This change is