fix Orientation handling #656
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The orientationdebouncer was always firing on rotation changes, interfering with lockOrientation calls from the player. This resulted in multiple rotations to the same orientation. Visible for the user were multiple changes in the video size when rotating the device. Also when Browser was locked to portrait, the very first landscape rotation did not register and needed to be called twice.
when honorSystemOrientationLock is false and rotateToLandscapeOnEnterFullScreen.isRotating is false video did not rotate to fullscreen.
The rotation lock button function now depends on the Settings. When "Follow device orientation lock" is enabled. Enabling rotation lock in the player will not rotate into landscape when hitting the fullscreen button. When "Follow device orientation lock" is disabled, it will prevent the player from going into fullscreen on device rotation, but goes into fullscreen with landscape when hitting the fullscreen button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orientationdebouncer was always firing on rotation changes, interfering with lockOrientation calls from the player. This resulted in multiple rotations to the same orientation. Visible for the user were multiple changes in the video size when rotating the device.
Moreover, when Browser was locked to portrait, the very first landscape rotation did not register and needed to be called twice.
Should also fix #499