Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter title on jump #655

Merged
merged 5 commits into from May 16, 2024
Merged

Chapter title on jump #655

merged 5 commits into from May 16, 2024

Conversation

stonerl
Copy link
Collaborator

@stonerl stonerl commented May 3, 2024

When a user taps on a chapter, the pop-up now also shows the name of the chapter. The chapters are now marked in AppRedColor instead of orange.

This is based on PR #639 (SponsorBlock Improvements)

That one needs to be merged first before this one can go in.

Default colors are defined in alignment to upstream. These can be changed by the user.
The colors are also used in the Timeline and the seek view.
Show/Hide categories in timeline.
Show/Hide notice after skip.
Show adjusted or actual total time.
When a user taps on a chapter, the pop now also shows the name of the chapter. The chapters are now marked in AppRedColor instead of orange.

This is based on PR yattee#639

That one needs to be merged first before this one can go in.
@arekf arekf merged commit 68f3d5c into yattee:main May 16, 2024
@stonerl stonerl deleted the chapter-title-on-jump branch May 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants