Restart finished video #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonerl
force-pushed
the
EOF-start-playback-again
branch
2 times, most recently
from
fcdb478
to
e262d59
Compare
stonerl
added a commit
to stonerl/yattee
that referenced
this pull request
Apr 26, 2024
When the time stamp for the last segment is greater the duration currently the video pauses. This interferes with PR yattee#646. Now instead of pausing we jump to the duration (end time) of the video instead.
stonerl
added a commit
to stonerl/yattee
that referenced
this pull request
Apr 26, 2024
When the time stamp for the last segment is greater the duration currently the video pauses. This interferes with PR yattee#646. Now instead of pausing we jump to the duration (end time) of the video instead.
After the video has ended, hitting play restarts the video from the beginning fixes yattee#449 If I understand the issue correctly, however, videos can now be played again without hitting the "Start from the beginning" button.
stonerl
force-pushed
the
EOF-start-playback-again
branch
from
e262d59
to
86b9191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the video has ended, hitting play restarts the video from the beginning
fixes #449
If I understand the issue correctly, however, videos can now be played again without hitting the "Start from the beginning" button.