Fix #619: Remove ports from shared YouTube links #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix yattee#619: Remove ports from shared YouTube links
|
To me this looks more like a workaround. It seems that the frontendHost gets constructed with the e.g. the invidious instance and only the url part is changed to YouTube afterwards. A better solution would be to construct the frontendHost correctly in the first place. Just my 2 cents, though … |
|
I updated the shareURL function and it's caller to handle schemas and ports correctly, and more generically than before. It no longer always uses the active instance's schema and port to form the shared URL, and instead can receive and parse a URL string for that information. |
arekf
requested changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #619 describes how when the app is connected to a frontend hosted on a non-standard port, that port gets added to shared YouTube links.
This change removes ports from shared YouTube links.