Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missusage of Sass rgba global function #159

Merged
merged 2 commits into from Feb 24, 2022
Merged

Fix missusage of Sass rgba global function #159

merged 2 commits into from Feb 24, 2022

Commits on Feb 24, 2022

  1. Fix missusage of Sass rgba global function 

    The alpha channel was using a percentage without the "%" symbol, which
was producing the rgb color instead.

See https://sass-lang.com/documentation/modules#rgb

> The alpha channel can be specified as either a unitless number between
> 0 and 1 (inclusive), or a percentage between 0% and 100% (inclusive)
    @dgdavid
    dgdavid committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    99cf9c0 View commit details
    Browse the repository at this point in the history

  2. Avoid using the built-in rgba function 

    Because it produces a CSS rgba function not fully compatible with Qt
rgba function, which expect the alpha channel in a percentaje value
between 0 and 100, instead of a unitless one between 0 and 1.

https://doc.qt.io/qt-5/stylesheet-reference.html
    @dgdavid
    dgdavid committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    5776f39 View commit details
    Browse the repository at this point in the history