Generic crawl controller #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved CrawlControler logic into a parametrizable version, GenericCrawlControler, which allows to specify the minimum WebCrawler class allowed. Declared protected Object collectCrawlerData(CrawlerType crawler) and called it inside start to extract data from crawler, so subclases can override it for custom data extraction based on WebCrawler type.
GenericWebCrawler is parametrizable, so it allows GenericCrawlController to parametrize results aswell.
|
@yasserg Could you merge this pr? Since there's no new release for 2 years after 2018, I'm building and using newest snapshot for myself and I really like this one with generic type. Really appreciate it! |
|
Please, let me know if those commits are hard to read (everything looks deleted and created again, so it may be kinda messy to review), i'll try a different aproach (with more separated commits) so git can detect changes in a better way, so it is "more reviewable". I'll create a new branch from scratch and apply the exact same changes, will not take much time ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github don't seem to detect moved files even if they were detected locally. I tried to do it in separated commits and same bad results. IT looks like everything changed, but it just the parameters added
I just renamed CrawlController to GenericCrawlController and WebCrawler to GenericWebCrawler. I make them parametrizable and created new CrawlController and WebCrawler that extends them to maintain retrocompatibility with everything that considered them non-parametrizable.
With this changes, getCrawlersLocalData can actually return a list of ResultType with no risks (provided all Java Generics considerations are taken into consideration.