Add tests for util #411
Open
Add tests for util #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrongly declared as int, causing the result to be incorrect for long values that do not fit in a int.
These tests were written using Diffbule Cover.
romainbrenguier
force-pushed
the
add-tests-for-util
branch
from
8abd8bc
to
bb2c4ad
Compare
|
Please merge this pull request @romainbrenguier thank you for the fix and the tests, good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that
edu.uic.ics.crawler4j.Utilwas not tested.I've written some tests for the methods in this class with the help of Diffblue Cover.
Along the way I found a bug in
byteArray2Longand implemented a fix for that.Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.