chore(deps): update deprecated deps for node 10 #5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BYK
approved these changes
Apr 30, 2018
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are a few upgrades of dependencies in order to address issues on node 10 (in relation to: #5477)
duplexify 3.5.0 => 3.5.4 (mafintosh/duplexify@00d08fa)
v8-compile-cache ^1.1.0 => ^2.0.0 (zertosh/v8-compile-cache#7)
natives 1.1.0 => 1.1.3 (gulpjs/gulp#2162)
The last did not have to do with
new Bufferbut was something I personally encountered when usinggulpfor building innode 10. I don't know how common this is, but the fix is easy and within scope, so decided to include it.Test plan
CI should be green.