fix(util): Allow git tag and branch name with hash

[torifat]

Summary

In Git # is a valid character for tag and branch

git check-ref-format "tags/v1.1.2-#279-require-twice-protection" && echo "Valid tag" || echo "Invalid tag"

Fixes #4880

[arcanis]

I'm a bit concerned by the ambiguity this change would add, which could cause issues in other parts of our stack that make the assumption that there can only be a single # character in a reference string. I'd personally be in favor of not supporting this syntax.

[torifat]

I agree. We can keep the old function as it is and handle multiple # inside git resolver. What do you think?

[kscc25]

@arcanis I don't agree, if yarn is supposed to support git tag, it must support all forms of valid tag.

[torifat]

I agree. We can keep the old function as it is and handle multiple # inside git resolver. What do you think?

@arcanis ☝️

[arcanis]

Sorry @torifat, I missed your comment! Problem with that is that it breaks a very common assumption about URLs, so I'm not sure it would work :/

Is it common to have hashes inside a branch name? I understand the "it's valid git" argument, but it's quite inconvenient nevertheless.

[BYK]

I think any legit # in the tag name should be URL encoded. Does that scenario work right now?

[BYK]

Agree with @arcanis here. I'm okay if we decode the part after the # sign.

[rally25rs]

I opened #5960 before realizing that this PR existed. I'll close mine since it's basically the same as this one.

My opinion is that unless we can prove that this does break something elsewhere in yarn, I don't see a reason to not support it. I don't think the branch/tag is used in a URL so I don't think it would need URL encoded. It's just passed through git commands or used when comparing the output of git refs.