Fix all variations of generateDisclaimer command to not have wrapper #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously 'yarn licenses generate-disclaimer' would not include the output wrapper header and footer but other valid variations such as 'yarn licenses generateDisclaimer' would. Fixes yarnpkg#1191
|
I'd prefer if we made the camelCased versions of the commands illegal instead of allowing this. |
sebmck
pushed a commit
that referenced
this pull request
Nov 1, 2016
|
Created #1586 to fix this, pending approval. |
sebmck
pushed a commit
that referenced
this pull request
Nov 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1191.
Previously
yarn licenses generate-disclaimerwould not include the output wrapper header and footer but other valid variations of the same command such asyarn licenses generateDisclaimerwould.Test plan
Previous behavior:
yarn licenses generate-disclaimeroutputs disclaimers without wrapperyarn licenses generateDisclaimeroutputs disclaimers with wrapperNew behavior:
yarn licenses generate-disclaimerandyarn licenses generateDisclaimerhave the same output without wrapper.