Prevent yarn install from getting in an infinite loop
#1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivertam
reviewed
Oct 24, 2016
| function isValidCommand(commandName: string, cmd: string): boolean { | ||
| // prevent infinite loop (see: https://github.com/yarnpkg/yarn/issues/1227) | ||
| // blocks `yarn`, `yarn i`, `yarn install`, with any flags as well | ||
| if (commandName.endsWith('install') && /^yarn(\si(nstall)?)?(\s\-.*)?$/.test(cmd)) { |
There was a problem hiding this comment.
can just return the opposite of this
if (boolean) {
return false;
}
return true;is a bit of an anti-pattern.
There was a problem hiding this comment.
Yes, I understand that. I was leaving it more open in case there are future exceptions that need to be made. I can always change it now to just return the opposite of the conditional and could revisit this pattern in the future when another condition is needed.
|
See my comment in #1227. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1227. It adds a check before executing the (pre/post)install lifecycle methods to make sure it won't get into an infinite loop. Not sure if this is the best way to handle it, so feedback is welcome.
Test plan
The lifecycle methods (pre/post)install can no longer get in a
yarn installinfinite loop.