Verify dist-tags key exists on object before querying range
#1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This appears to fix quite a few similar, possibly duplicate issues (#953, #1186, #1241, #1259, #1266, #1274). They all throw a similar error in
npm-resolver.js:TypeError: Cannot use 'in' operator to search for '<range>' in undefinedThis also seems like it could be a bandaid that would be masking a different problem. I unfortunately wasn't able to reproduce the issue myself. Even went as far as installing Windows 7 on VirtualBox and tried to reproduce.
Note
Also, it would be great to get some tests around the resolvers. I don't know much about Jest and snapshot testing and if it would be used for this. Any guidance in getting some tests in place would be awesome as well. Could even be done in a separate PR.
Test plan
No longer throw the
TypeErrorlisted above and have theinstall/add/upgradecommand work as expected.