Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align browser shim version #2350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: align browser shim version #2350

wants to merge 1 commit into from

Conversation

nomyfan
Copy link

@nomyfan nomyfan commented Jul 29, 2023

This PR can also resolve #1981

@shadowspawn
Copy link
Member

Oh drat, another stale hand-coded dependency outside package.json like #2306 ! I sense the need for a checklist... 😅

I'll take a more careful look, but my expectation is we want this. Thanks.

Copy link
Member

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I checked visually and checked dependency versions. Did not check runtime.)

@nomyfan
Copy link
Author

nomyfan commented Aug 1, 2023

Thank you for reviewing. Any release plan for this?

@shadowspawn
Copy link
Member

Any release plan for this?

Short version: no.

(Is this a blocker for something you are doing, or were you just wondering?)

@nomyfan
Copy link
Author

nomyfan commented Aug 2, 2023

I use yargs in my web project which is crashed caused by this. I had used pnpm patch to fix it as a workaround so it's not so urgent for me.
It would be nice to see the fix released in the coming version so that I can remove that patch.😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser version does not work (17.0.1)
2 participants