New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: boolean option should work with strict #1996
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e58eb81
fix: boolean option should work with strict
jly36963 79c76c1
Merge branch 'master' into fix-boolean-strict-bug
jly36963 acbd93b
Merge branch 'master' into fix-boolean-strict-bug
jly36963 2b1b65d
Merge branch 'master' into fix-boolean-strict-bug
jly36963 48c02f1
Merge branch 'master' into fix-boolean-strict-bug
jly36963 0a7f641
lint
jly36963 f466eef
Merge branch 'master' into fix-boolean-strict-bug
jly36963 c356666
Merge branch 'master' into fix-boolean-strict-bug
jly36963 2293c3b
Merge branch 'main' into fix-boolean-strict-bug
bcoe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't the
this[kPopulateParserHintArray]('boolean', keys);
function also populatethis.#options
?I'm wondering why we need this additional
kTrackManuallySetKeys
? I'm probably missing something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example code
Reason for the change
yargs.option
has this line:This line populates
options.key
.Before my fix, calling
yargs.boolean
(or array, count, string, number, etc) was missing this behavior.To highlight the difference in behavior between
.option()
and.boolean()
, I added opt1 and opt2 using.option()
. In the "Without fix" section below, you should see thatoptions.key
has opt1 and opt2, but is missing the others.Explanation
I logged options (
yargs.getOptions()
) inside ofvalidation.isValidAndSomeAliasIsNotNew
Without the fix,
options.key
is missing keys, soisValidAndSomeAliasIsNotNew
fails.Without fix:
WIth fix