Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to reproduce #1701 #1710

Closed
wants to merge 1 commit into from
Closed

add test to reproduce #1701 #1710

wants to merge 1 commit into from

Conversation

fcastilloec
Copy link

@fcastilloec fcastilloec commented Aug 6, 2020

I tried to simplify my scenario as much as possible, so I hope that this actually covers it and shows the difference between the previous and current behaviors.

@bcoe
Copy link
Member

bcoe commented Aug 7, 2020

@fcastilloec thank you for the failing test 👌

@bcoe
Copy link
Member

bcoe commented Aug 7, 2020

@fcastilloec I think you're right that it would be worth adding strirctOptions as a complement to strictCommands.

fcastilloec added a commit to fcastilloec/ieeeXploreSearching that referenced this pull request Aug 20, 2020
We need to test for unknown options but allow unknown arguments

See yargs/yargs#1701 and yargs/yargs#1710
@bcoe
Copy link
Member

bcoe commented Sep 8, 2020

closing in favor of #1738

@bcoe bcoe closed this Sep 8, 2020
fcastilloec added a commit to fcastilloec/ieeeXploreSearching that referenced this pull request Jan 27, 2021
We need to test for unknown options but allow unknown arguments

See yargs/yargs#1701 and yargs/yargs#1710
fcastilloec added a commit to fcastilloec/ieeeXploreSearching that referenced this pull request Apr 6, 2022
We need to test for unknown options but allow unknown arguments

See yargs/yargs#1701 and yargs/yargs#1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants