Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe yargs.async API surface #1491

Closed
wants to merge 3 commits into from
Closed

docs: describe yargs.async API surface #1491

wants to merge 3 commits into from

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Nov 25, 2019

Background

@mleguen and @petrgrishin, in #1473, #1488, #1420, and #1487, have kicked off a conversation about what a better thought out asynchronous API surface for yargs would look like ... After dragging my feet initially, I now officially find myself roped in 馃槅 ...

and getting a little bit excited about the potential of this cleaning up some of the ugly nooks and crannies of the yargs API.

What is This?

As suggested in #1487, I think we should start by collaborating on a document that thoroughly describes yargs' async API surface, before we dive in with the implementation

@bcoe
Copy link
Member Author

bcoe commented Dec 3, 2019

@petrgrishin I have slight concerns about the mixing of callbacks and promises in #1473, curious what your thoughts are on this PR as a potential direction for async behavior, mainly getting a promise back from a command if the command has a promise.

@bcoe
Copy link
Member Author

bcoe commented Jan 2, 2020

@mleguen, looks like we're opting to start with @petrgrishin's implementation? I still think this might be worth revisiting, would potentially be nice to have a way to opt into promises from yargs rather than using callbacks, but let's see if folks like the approach released in yargs@15.1.0?

@bcoe bcoe closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant