Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I-1178: Middleware fix #1180

Merged
merged 2 commits into from Aug 11, 2018
Merged

I-1178: Middleware fix #1180

merged 2 commits into from Aug 11, 2018

Conversation

aorinevo
Copy link
Contributor

@aorinevo aorinevo commented Jul 6, 2018

@aorinevo aorinevo requested a review from bcoe July 6, 2018 09:02
@aorinevo aorinevo mentioned this pull request Jul 6, 2018
Closed
@aorinevo
Copy link
Contributor Author

aorinevo commented Jul 6, 2018

@bcoe, any idea why coverage step is failing?

@bcoe
Copy link
Member

bcoe commented Aug 11, 2018

@aorinevo lovely, thank you for this fix 👍 sorry I've been so AWOL lately, I've been deep ending on npm and Node.js work.

bcoe
bcoe approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐅this fix is grrrreat.

@bcoe bcoe merged commit 664b265 into master Aug 11, 2018
@bcoe bcoe deleted the I-1178_master_AN_middleware_fix branch August 11, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global middleware don't work in 12.0.1
2 participants
@aorinevo @bcoe