fix: [object Object] was accidentally being populated on options obje…

…ct (#736)
yargs · Dec 17, 2016 · f755e27 · f755e27
1 parent 27e1a57
commit f755e27
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/test/yargs.js b/test/yargs.js
@@ -64,6 +64,8 @@ describe('yargs dsl tests', function () {
     })
 
     r.errors[0].should.match(/really cool key/)
+    r.result.should.have.property('x')
+    r.result.should.not.have.property('[object Object]')
   })
 
   it('treats usage as alias for options, if object provided as first argument', function () {

diff --git a/yargs.js b/yargs.js
@@ -383,7 +383,13 @@ function Yargs (processArgs, cwd, parentRequire) {
   }
 
   self.describe = function (key, desc) {
-    options.key[key] = true
+    if (typeof key === 'object') {
+      Object.keys(key).forEach(function (k) {
+        options.key[k] = true
+      })
+    } else {
+      options.key[key] = true
+    }
     usage.describe(key, desc)
     return self
   }