fix: positional arguments now work if no handler is provided to inner…

… command (#864)

BREAKING CHANGE: this pull requests introduces language features that require Node 4+.

.travis.yml

@@ -7,7 +7,6 @@ os:
 after_success: npm run coverage
 
 node_js:
-  - "0.10"
-  - "0.12"
   - "4"
+  - "6"
   - "node"

appveyor.yml

@@ -3,9 +3,9 @@
 # Test against these versions of Node.js.
 environment:
   matrix:
-    - nodejs_version: "0.10"
     - nodejs_version: "4"
     - nodejs_version: "6"
+    - nodejs_version: "7"
 
 # Install scripts. (runs after repo cloning)
 install:

lib/command.js

@@ -15,6 +15,8 @@ module.exports = function (yargs, usage, validation) {
   var defaultCommand
   self.addHandler = function (cmd, description, builder, handler) {
     var aliases = []
+    handler = handler || function () {}
+
     if (Array.isArray(cmd)) {
       aliases = cmd.slice(1)
       cmd = cmd[0]

test/command.js

@@ -409,7 +409,7 @@ describe('Command', function () {
       var handlers = y.getCommandInstance().getCommandHandlers()
       handlers.foo.original.should.equal(module.command)
       handlers.foo.builder.should.equal(module.builder)
-      expect(handlers.foo.handler).to.equal(undefined)
+      expect(typeof handlers.foo.handler).to.equal('function')
       var commands = y.getUsageInstance().getCommands()
       commands[0].should.deep.equal([module.command, module.describe, isDefault, aliases])
     })
@@ -1339,4 +1339,18 @@ describe('Command', function () {
         argv._.should.eql(['bar', 'foo'])
       })
   })
+
+  // see: https://github.com/yargs/yargs/issues/861 phew! that's an edge-case.
+  it('should allow positional arguments for inner commands in strict mode, when no handler is provided', () => {
+    yargs()
+      .command('foo', 'outer command', (yargs) => {
+        yargs.command('bar [optional]', 'inner command')
+      })
+      .strict()
+      .parse('foo bar 33', function (err, argv) {
+        expect(err).to.equal(null)
+        argv.optional.should.equal(33)
+        argv._.should.eql(['foo', 'bar'])
+      })
+  })
 })