test: simplify coverage enforcement (#1578)

.github/workflows/ci.yaml

@@ -33,10 +33,7 @@ jobs:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 13
       - run: npm install
       - run: npm test
       - run: npm run coverage
-    env:
-      COVERALLS_REPO_TOKEN: "${{ secrets.COVERALLS_REPO_TOKEN }}"
-      COVERALLS_GIT_BRANCH: "${{ github.ref }}"

README.md

@@ -9,7 +9,6 @@
 <br>
 
 [![Build Status][travis-image]][travis-url]
-[![Coverage Status][coveralls-image]][coveralls-url]
 [![NPM version][npm-image]][npm-url]
 [![js-standard-style][standard-image]][standard-url]
 [![Conventional Commits][conventional-commits-image]][conventional-commits-url]
@@ -127,8 +126,6 @@ Having problems? want to contribute? join our [community slack](http://devtoolsc
 
 [travis-url]: https://travis-ci.org/yargs/yargs
 [travis-image]: https://img.shields.io/travis/yargs/yargs/master.svg
-[coveralls-url]: https://coveralls.io/github/yargs/yargs
-[coveralls-image]: https://img.shields.io/coveralls/yargs/yargs.svg
 [npm-url]: https://www.npmjs.com/package/yargs
 [npm-image]: https://img.shields.io/npm/v/yargs.svg
 [standard-image]: https://img.shields.io/badge/code%20style-standard-brightgreen.svg

lib/usage.js

@@ -500,6 +500,8 @@ module.exports = function usage (yargs, y18n) {
   // guess the width of the console window, max-width 80.
   function windowWidth () {
     const maxWidth = 80
+    // CI is not a TTY
+    /* c8 ignore next 2 */
     if (typeof process === 'object' && process.stdout && process.stdout.columns) {
       return Math.min(maxWidth, process.stdout.columns)
     } else {

package.json

@@ -35,7 +35,6 @@
     "c8": "^7.0.0",
     "chai": "^4.2.0",
     "chalk": "^3.0.0",
-    "coveralls": "^3.0.3",
     "cpr": "^3.0.1",
     "cross-spawn": "^7.0.0",
     "es6-promise": "^4.2.5",
@@ -50,7 +49,7 @@
     "fix": "standard --fix",
     "posttest": "standard",
     "test": "c8 --reporter=html --reporter=text mocha --require ./test/before.js --timeout=12000 --check-leaks",
-    "coverage": "c8 report --reporter=text-lcov | coveralls"
+    "coverage": "c8 report --check-coverage check-coverage --lines=100 --branches=96 --statements=100"
   },
   "repository": {
     "type": "git",

test/yargs.js

@@ -580,11 +580,11 @@ describe('yargs dsl tests', () => {
 
   describe('terminalWidth', () => {
     it('returns the maximum width of the terminal', function () {
-      if (!process.stdout.isTTY) {
-        return this.skip()
+      if (process.stdout.isTTY) {
+        yargs.terminalWidth().should.be.gte(0)
+      } else {
+        expect(yargs.terminalWidth()).to.equal(null)
       }
-
-      yargs.terminalWidth().should.be.gte(0)
     })
   })