fix: don't load config when processing positionals

yargs · Nov 10, 2018 · 5d0dc92 · 5d0dc92
1 parent 128f322
commit 5d0dc92
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 39 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -4,6 +4,7 @@ node_js:
   - "6"
   - "8"
   - "10"
+  - "node"
 
 os:
   - linux

diff --git a/appveyor.yml b/appveyor.yml
diff --git a/lib/command.js b/lib/command.js
@@ -331,6 +331,7 @@ module.exports = function command (yargs, usage, validation, globalMiddleware) {
     options.default = Object.assign(parseOptions.default, options.default)
     options.alias = Object.assign(parseOptions.alias, options.alias)
     options.array = options.array.concat(parseOptions.array)
+    delete options.config //  don't load config when processing positionals.
 
     const unparsed = []
     Object.keys(positionalMap).forEach((key) => {

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
     "string-width": "^2.0.0",
     "which-module": "^2.0.0",
     "y18n": "^3.2.1 || ^4.0.0",
-    "yargs-parser": "^11.0.0"
+    "yargs-parser": "^11.1.0"
   },
   "devDependencies": {
     "chai": "^4.1.2",

diff --git a/test/command.js b/test/command.js
@@ -110,6 +110,31 @@ describe('Command', () => {
       argv.file.should.equal('foo.js')
       argv.reporter.should.equal('html')
     })
+
+    // bug reported by @boneskull during mocha migration.
+    it('does not load config twice when command executed', () => {
+      let parseCount = 0
+      yargs('cmd --config=.foo.json')
+        .command(
+          '$0 [foo..]',
+          'does a thing',
+          yargs =>
+            yargs
+              .option('config', {
+                default: '.foo.json'
+              })
+              .positional('foo', {
+                description: 'bar'
+              })
+              .config('config', filepath => {
+                parseCount++
+                return {}
+              }),
+          argv => {}
+        )
+        .parse()
+      parseCount.should.equal(1)
+    })
   })
 
   describe('variadic', () => {