Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: boolean-negation configuration option wrong behaviour #377

Closed
wants to merge 1 commit into from
Closed

fix: boolean-negation configuration option wrong behaviour #377

wants to merge 1 commit into from

Conversation

ArthurKa
Copy link
Contributor

Fix issue #376.

@ArthurKa ArthurKa changed the title fix: boolean-negation wrong behaviour fix: boolean-negation configuration option wrong behaviour Apr 21, 2021
@jackcarnes
Copy link

approved

jackcarnes
jackcarnes approved these changes Apr 29, 2021
View reviewed changes
Copy link

@jackcarnes jackcarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appoved

@ArthurKa
Copy link
Contributor Author

ArthurKa commented Apr 29, 2021 •
edited

Double approval ;)

@bcoe
Copy link
Member

bcoe commented Jun 20, 2021

@ArthurKa sorry for the slow turnaround on this. Could I bother you to add a unit test for this behavior, otherwise it will regress again 😆

@bcoe bcoe closed this Jun 20, 2021
@bcoe bcoe deleted the branch yargs:master June 20, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackcarnes jackcarnes jackcarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArthurKa @jackcarnes @bcoe