Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(deps): update dependency decamelize to v3" #277

Closed
wants to merge 1 commit into from
Closed

Revert "fix(deps): update dependency decamelize to v3" #277

wants to merge 1 commit into from

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jun 3, 2020

Reverts #274

@bcoe
Copy link
Member Author

bcoe commented Jun 3, 2020

@QmarkC I landed #274 prematurely, the issue with pulling in a new decamelize is the dependency xregexp, which does exist in `3.2.0 -- I remember now why I was holding off on upgrading decamelize.

xregexp is 699.5kb unpacked, 6x the times of yargs-parser itself.

@bcoe bcoe closed this Jun 6, 2020
@bcoe bcoe deleted the revert-274-update-decamelize-3.x branch June 6, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QmarkC QmarkC QmarkC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcoe @QmarkC