fix(populate--): -- should always be array (#354)

yargs · Feb 22, 2021 · 585ae8f · 585ae8f
1 parent a4000b6
commit 585ae8f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/yargs-parser.ts b/lib/yargs-parser.ts
@@ -214,6 +214,11 @@ export class YargsParser {
       // any unknown option (except for end-of-options, "--")
       if (arg !== '--' && isUnknownOptionAsArg(arg)) {
         pushPositional(arg)
+      // ---, ---=, ----, etc,
+      } else if (arg.match(/---+(=|$)/)) {
+        // options without key name are invalid.
+        pushPositional(arg)
+        continue
       // -- separated by =
       } else if (arg.match(/^--.+=/) || (
         !configuration['short-option-groups'] && arg.match(/^-.+=/)

diff --git a/test/yargs-parser.cjs b/test/yargs-parser.cjs
@@ -3244,6 +3244,17 @@ describe('yargs-parser', function () {
           k: true
         })
       })
+      // See: https://github.com/yargs/yargs/issues/1869
+      // ----=hello ---=hello ---- hello.
+      it('should not populate "--" for key values other than "--"', () => {
+        const argv = parser('----=test', {
+          configuration: {
+            'populate--': true
+          }
+        })
+        argv._.should.eql(['----=test'])
+        expect(argv['--']).to.equal(undefined)
+      })
       // see: https://github.com/yargs/yargs/issues/1489
       it('should identify "hasOwnProperty" as unknown option', () => {
         const argv = parser('--known-arg=1 --hasOwnProperty=33', {