fix(unknown-options-as-args): '--' is not an unknown option (#207)

yargs · Oct 15, 2019 · 3fee2d8 · 3fee2d8
1 parent afcaecb
commit 3fee2d8
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -143,7 +143,8 @@ function parse (args, opts) {
     var next
     var value
 
-    if (isUnknownOptionAsArg(arg)) {
+    // any unknown option (except for end-of-options, "--")
+    if (arg !== '--' && isUnknownOptionAsArg(arg)) {
       argv._.push(arg)
     // -- separated by =
     } else if (arg.match(/^--.+=/) || (

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -2894,6 +2894,36 @@ describe('yargs-parser', function () {
           k: true
         })
       })
+
+      it('should not identify "--" as an unknown option', function () {
+        const argv = parser('-a -k one -1 -- -b -k two -2', {
+          boolean: ['k'],
+          configuration: {
+            'unknown-options-as-args': true
+          }
+        })
+        argv.should.deep.equal({
+          _: ['-a', 'one', -1, '-b', '-k', 'two', '-2'],
+          k: true
+        })
+      })
+
+      it('should not identify "--" as an unknown option when "populate--" is true', function () {
+        const argv = parser('-a -k one -1 -- -b -k two -2', {
+          boolean: ['k'],
+          configuration: {
+            'populate--': true,
+            'unknown-options-as-args': true
+          }
+        })
+        argv.should.deep.equal({
+          // populate argv._ with everything before the --
+          _: ['-a', 'one', -1],
+          // and argv['--'] with everything after the --
+          '--': ['-b', '-k', 'two', '-2'],
+          k: true
+        })
+      })
     })
   })