Fixing axios#433 - instance should inherit defaults

yanivefraim · Nov 8, 2016 · 194f41a · 194f41a
1 parent 949d08d
commit 194f41a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/axios.js b/lib/axios.js
@@ -31,7 +31,7 @@ axios.Axios = Axios;
 
 // Factory for creating new instances
 axios.create = function create(defaultConfig) {
-  return createInstance(defaultConfig);
+  return createInstance(utils.merge(axios.defaults, defaultConfig));
 };
 
 // Expose Cancel & CancelToken

diff --git a/test/specs/instance.spec.js b/test/specs/instance.spec.js
@@ -68,6 +68,19 @@ describe('instance', function () {
     expect(typeof instance.defaults.headers.common, 'object');
   });
 
+  it('should inherit defaults options', function (done) {
+    var oldBaseURL = axios.defaults.baseURL;
+    axios.defaults.baseURL = 'http://example.com/';
+    var instance = axios.create();
+    instance.get('/foo');
+
+    getAjaxRequest().then(function (request) {
+      expect(request.url).toBe('http://example.com/foo');
+      axios.defaults.baseURL = oldBaseURL;
+      done();
+    });
+  });
+
   it('should have interceptors on the instance', function (done) {
     axios.interceptors.request.use(function (config) {
       config.foo = true;