This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
14.04 #2
Closed
14.04 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2015 00:10
- This creates a new directory ./14.04, or ./12.04 - I'm not sure if this is the best way. See yammer#1
| RUN apt-get -y install libboost-program-options1.54-dev | ||
| RUN apt-get -y update && if [ ${RELEASE} = "12.04" ]; then \ | ||
| ./build/deps_ubuntu_12.04.sh && apt-get -y install libboost-program-options1.54-dev; else \ | ||
| apt-get install -y \ |
There was a problem hiding this comment.
I wonder if we could get upstream to add a ./build/deps_ubuntu_14.04.sh similar to the 12.04 script. That'd make building this much easier and would allow the project to own their dependency list.
|
That would be ideal. |
|
I noticed that this was just added to Docker 1.9 for build-time arguments. I think this might be exactly what we need here. |
|
closing as I'm going to submit a new PR based on your improvements |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect you to merge this in yet. It's just here for reference to #1 .
If you did merge it however, nothing should change for you except that the .deb file will be located in
./12.04/instead of./