fix(notice): fix limit 1 on useNotice does not work

[108yen]

Closes #695

Description

fix limit 1 on useNotice does not work

Current behavior (updates)

Setting the limit value to 1 does not limit the number of displays.

New behavior

If the limit is set to 1, only one is displayed.
If an invalid value such as -1 is set for the limit value, it is ignored.

Is this a breaking change (Yes/No): No

Additional Information

NIL

[changeset-bot]

🦋 Changeset detected

Latest commit: 47794e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@yamada-ui/notice	Patch
@yamada-ui/providers	Patch
@yamada-ui/react	Patch
@yamada-ui/use-media-query	Patch
@yamada-ui/test	Patch
vite	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[illionillion]

@108yen
When I press the button quickly and repeatedly, sometimes more than one notice appears, even when the limit value is 1.

If Yamada UI uses framer-motion internally, this may be a bug of it.

2024-02-08.17.25.15.mov

[108yen]

@illionillion
I think it is this isssue.
framer/motion#2462

Removing AnimatePresence in notice-provider.tsx will work correctly.

<AnimatePresence initial={false}>
    {notices.map((notice) => (
      <NoticeComponent key={notice.id} variants={variants} {...notice} />
    ))}
</AnimatePresence>

[illionillion]

@illionillion I think it is this isssue. framer/motion#2462

Removing AnimatePresence in notice-provider.tsx will work correctly.

<AnimatePresence initial={false}>
    {notices.map((notice) => (
      <NoticeComponent key={notice.id} variants={variants} {...notice} />
    ))}
</AnimatePresence>

@108yen
Thanks.
Please correct it that way.

[108yen]

@illionillion
If you remove AnimatePresence, the bug will be fixed, but the animation won’t be rendered. Is that okay? Since it’s a minor bug, waiting for a fix in framer-motion might be a good idea

notice.mp4

[illionillion]

@illionillion If you remove AnimatePresence, the bug will be fixed, but the animation won’t be rendered. Is that okay? Since it’s a minor bug, waiting for a fix in framer-motion might be a good idea

notice.mp4

That's not good.
Let's wait for the framer-motion to fix it.
I think it is good to merge.

[illionillion]

Approved