Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the theme CSS code #1570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remi-grumeau
Copy link

  • Adding CSS variables for colors to make theme forks or customisation easy
  • Make all sizes relative to improve responsive
  • Remove weird pseudo elements positioning for top/bottom arrow
  • Remove float & switch to flex display
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets not that i know of
License MIT

Description

Just got my hands on medium editor, and thought this might be handy for a few people.
A few more could be done but might involve breaking BC.

--

Please, don't submit /dist files with your PR!

- Adding CSS variables for colors to make theme forks or customisation easy
- Make all sizes relative to improve responsive
- Remove weird pseudo elements positioning for top/bottom arrow
- Remove float & switch to flex display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant