Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox createLink bug workaround #1364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

apptaro
Copy link

@apptaro apptaro commented Aug 25, 2017

This fix workarounds FireFox createLink bug.
Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=451142

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d0c3ebe on apptaro:ffcreatelinkbug into ** on yabwe:master**.

@apptaro
Copy link
Author

apptaro commented Aug 25, 2017

Without this fix and if you use Firefox, you can't create a link to url like http://www.städtlifest.ch/

@j0k3r
Copy link
Contributor

j0k3r commented Aug 25, 2017

Could you add a test for that?

@apptaro
Copy link
Author

apptaro commented Aug 25, 2017

I am not very familiar with jasmine testing framework that this project uses. Can I write firefox specific testing code? It seems to me that jasmine uses phantomjs which is webkit based.

@j0k3r
Copy link
Contributor

j0k3r commented Aug 25, 2017

Just write your test code to validate your change is ok, I guess it shouldn't introduce side behavior on other browser.
The default build use phantomjs but when merged to master we use Saucelabs to run against many different browsers

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 83f8f1f on apptaro:ffcreatelinkbug into ** on yabwe:master**.

@apptaro
Copy link
Author

apptaro commented Sep 1, 2017

I added the test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants