A few changes related to language #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language not specifically translated is better served English. In case any variant should get Chinese, please add those as zh.
Efficient fallback to default.
JAGulin
commented
Jul 10, 2021
| @@ -1,5 +1,5 @@ | |||
| // ==UserScript== | |||
| // @name HTML5视频播放器增强脚本 | |||
There was a problem hiding this comment.
There may be side effects of changing the official name. Possibly TM or GreasyFork might think it's a new script, rather than a change to the existing one.
https://greasyfork.org/en/discussions/greasyfork/75556-when-a-script-name-is-changed-greasyfork-doesn-t-recognize-the-old-script
This needs to be well tested. Changing description and other things should be safe and could be first step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are meant to make the plugin and development more accessible for others.
Let me know if you prefer to have each change in a separate pull-request. Only the last patch (output) depend on the previous (tipsI).
Closes #271