Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert, emplace, erase, push_back and pop_back #86

Merged
merged 9 commits into from
May 23, 2024

Conversation

Alex-PLACET
Copy link
Contributor

Implement #34

@Alex-PLACET Alex-PLACET marked this pull request as ready for review May 7, 2024 14:17
include/sparrow/buffer.hpp Outdated Show resolved Hide resolved
include/sparrow/buffer.hpp Outdated Show resolved Hide resolved
include/sparrow/buffer.hpp Outdated Show resolved Hide resolved
include/sparrow/buffer.hpp Outdated Show resolved Hide resolved
include/sparrow/buffer.hpp Show resolved Hide resolved
test/test_buffer.cpp Outdated Show resolved Hide resolved
test/test_buffer.cpp Show resolved Hide resolved
test/test_buffer.cpp Show resolved Hide resolved
test/test_buffer.cpp Show resolved Hide resolved
test/test_buffer.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the necessary renaming, LGTM!

include/sparrow/buffer.hpp Outdated Show resolved Hide resolved
test/test_buffer.cpp Show resolved Hide resolved
test/test_buffer.cpp Outdated Show resolved Hide resolved
@Klaim Klaim merged commit 6a725bf into xtensor-stack:main May 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants