Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 182 (Enhance XSLTCoverageTraceListener) #189

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Issue 182 (Enhance XSLTCoverageTraceListener) #189

wants to merge 17 commits into from

Conversation

cmarchand
Copy link
Collaborator

A proposal to solve Issue 182
I could maybe remove the @authors list in javadoc

@cmarchand
Copy link
Collaborator Author

Could someone give a test under Windows ?
Install Maven, then

mvn test 

It should display a "Build success" message

@AirQuick AirQuick changed the title Issue 182 Issue 182 (Enhance XSLTCoverageTraceListener) Mar 30, 2018
@AirQuick
Copy link
Member

AirQuick commented Apr 1, 2018

I will, but after handling #188.

@AirQuick AirQuick self-requested a review April 1, 2018 13:36
@AirQuick
Copy link
Member

AirQuick commented Apr 2, 2018

mvn test worked fine on Windows. I'm going to check the other things.

@AirQuick
Copy link
Member

AirQuick commented Apr 2, 2018

I confirmed that the coverage XML was now written to a file specified by com.jenitennison.xsl.tests.coverage.output. This is the first time I see the coverage XML is made well-formed.😅 Thanks for the improvement.

I committed some changes of xspec.sh and xspec.bat in your branch. They set the new system properties without trying to normalize their values at all. It is very much appreciated if any platform or environment differences are absorbed within XSLTCoverageTraceListener.

@AirQuick
Copy link
Member

AirQuick commented Apr 2, 2018

So,

  • Can you update XSLTCoverageTraceListener.class, too?

  • With the updated xspec.sh and xspec.bat, I've observed these values at the beginning of enter(), for example:

computedGenerateTestUtilsName=C:\Users\User\Desktop\xspec\bin\..\src\compiler\generate-tests-utils.xsl
computedIgnoreDir=C:\Users\User\Desktop\xspec\tutorial\xspec
systemId=file:/C:/Users/User/Desktop/xspec/src/compiler/generate-tests-utils.xsl
computedGenerateTestUtilsName=../src/compiler/generate-tests-utils.xsl
computedIgnoreDir=../tutorial/xspec
systemId=file:/home/user/test/xspec/test/../tutorial/xspec/escape-for-regex.xsl

To get them work, the following tweaks or something like them would be necessary, perhaps? (Just my quick thought, and I scarcely know Java. So please do what you think is the best.)

  • com.jenitennison.xsl.tests.coverage.generate-tests-utils: File(value).toURI().normalize()
  • com.jenitennison.xsl.tests.coverage.ignore-dir: File(value + File.separator).toURI().normalize()
  • systemId: URI(value).normalize()

@cirulls cirulls added this to the v1.1.0 milestone Jun 24, 2018
@AirQuick AirQuick removed this from the v1.1.0 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants