Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide FITS file implementation of the CustomInstrument classes #194

Open
sguillot opened this issue Jan 11, 2023 · 0 comments
Open

Provide FITS file implementation of the CustomInstrument classes #194

sguillot opened this issue Jan 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sguillot
Copy link
Contributor

The CustomInstrument classes provided either in the tutorials or the Zenodo can be confusing. I think it could be greatly simplified by allowing the use to load directly from the FITS files. Response matrices (RMF and ARF) are standardised in X-ray astronomy, so there should not be any complications. It should be also relatively easy to extract the channels edges and to figure out from the file header if the RMF has already been multipled by the ARF or not.

This suggested feature should probably be tackled after the python3 release (since reading FITS file will rely on Astropy, and we will likely face difficulties with astropy version that are only compatible with Python 2)

@sguillot sguillot added the enhancement New feature or request label Jan 11, 2023
@sguillot sguillot changed the title Provide simpler CustomInstrument classes Provide FITS file implementation of the CustomInstrument classes Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant