Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the creation of a CustomInstrument from response matrice #320

Open
sguillot opened this issue Aug 16, 2023 · 0 comments
Open

Simplify the creation of a CustomInstrument from response matrice #320

sguillot opened this issue Aug 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sguillot
Copy link
Contributor

The max/min input and max/min channels may be difficult to adjust as the choice of values can raise errors if some rows or columns of the matrix are filled with zero (or negative) values. By itself this is not a problem and this was implemented to save computing time.

The current error message tells the user to reduce the channels ranges to avoid this issue, without explaining the reason behind it. This could be clarified.

In practice, it shouldn't be necessary for the user to specify any range of max/min input and max/min channels. The full matrix should be loaded, and then only the part of the matrix relevant to the input data should be use for the calculation.

I think this could be transparent to the user (as it is currently for all X-ray spectral analysis packages), and therefore less complicated for the creation of the CustomInstrument, with perhaps some messages displayed to indicate the range of channels used.

Such improvement could be implemented at the same time as the FITS file implementation of the response matrices (#194)

@sguillot sguillot added the enhancement New feature or request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant