Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI for Unicode codepoint collation #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix URI for Unicode codepoint collation #684

wants to merge 1 commit into from

Conversation

ndw
Copy link
Contributor

@ndw ndw commented Mar 27, 2024

@xml-project xml-project self-requested a review March 27, 2024 13:07
xml-project
xml-project requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@xml-project xml-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change, but I don't want to merge it yet. The test is correct given the current specification. I think it might lead to confusion if we change the test, and possible one errata with handling the others.
Does this make sense?

@ndw
Copy link
Contributor Author

ndw commented Mar 27, 2024

Yes. It's a breaking change and a fiddly one to find. It might be better to code around it. I'll add a note to the other bug about that.

@xml-project xml-project self-requested a review March 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimsieke gimsieke gimsieke approved these changes

@xml-project xml-project xml-project approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndw @gimsieke @xml-project