Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CPU microarchitecture on ARMv7 for better performance #3087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Botspot
Copy link

@Botspot Botspot commented Jul 13, 2022

@Spudz76
Copy link
Contributor

Spudz76 commented Jul 13, 2022

Pull Requests must be based on dev branch, not master

@SChernykh
Copy link
Contributor

Also, it's better to take the whole fresh https://github.com/DLTcollab/sse2neon/blob/master/sse2neon.h than updating single line there.

@Botspot
Copy link
Author

Botspot commented Jul 13, 2022

Pull Requests must be based on dev branch, not master

How do I do that?

@Spudz76
Copy link
Contributor

Spudz76 commented Jul 14, 2022

git checkout dev

git branch dev-tweakArmNative

git checkout dev-tweakArmNative

curl -s https://patch-diff.githubusercontent.com/raw/xmrig/xmrig/pull/3087.diff | patch -p1

git commit -a

git push --set-upstream origin dev-tweakArmNative

Then edit the branches in this PR or make a new one (not sure if you can edit the branches on existing).

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=armv7-a -mfpu=neon")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=armv7-a -mfpu=neon -flax-vector-conversions")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mcpu=native -mfpu=neon")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mcpu=native -mfpu=neon -flax-vector-conversions")
Copy link
Contributor

@dev-0x7C6 dev-0x7C6 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this will work for cross compilation environment, I think this is not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants