Fix minor leaks and some unintialized components (valgrind) #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SChernykh
suggested changes
Nov 29, 2021
|
Those only showed up during the GR optimizer phase and were quite spammy. I hadn't seen them before with normal CN algos, somehow. Had to patch them to see the other leaks, will revert those mainloop inits. |
Spudz76
force-pushed
the
dev-fixGRLeaks
branch
from
c5e72c9
to
e7381ee
Compare
|
I think zeroing the buf and hash within ghostrider actually fixed the uninitialized condition in the CN code which is how it doesn't show up except in the GR optimizer phase. I also patched that after patching the CN code so that makes sense. |
Spudz76
force-pushed
the
dev-fixGRLeaks
branch
from
e7381ee
to
9c47205
Compare
|
Adjusted whitespace since I found a code-standard precedent for using |
Spudz76
force-pushed
the
dev-fixGRLeaks
branch
2 times, most recently
from
0a9d492
to
b61d46d
Compare
Spudz76
force-pushed
the
dev-fixGRLeaks
branch
2 times, most recently
from
8eccc11
to
4c9376a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix benchmark feature when
WITH_RANDOMX=OFF