Only add subdirectories if necessary #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this will work since the the USE_* variables use generator expressions and they get evaluated at build time, whereas the |
skitt
force-pushed
the
conditional-subdirectories
branch
from
4c231d1
to
0baed68
Compare
It turns out that using explicit variable evaluations ( |
skitt
force-pushed
the
conditional-subdirectories
branch
from
0baed68
to
a822826
Compare
If the build is using system libraries (for bzip2, lua, ode, or xdgbasedir), there's no need to add the corresponding subdirectories. This reduces build time and avoids potential mix-ups. Signed-off-by: Stephen Kitt <steve@sk2.org>
skitt
force-pushed
the
conditional-subdirectories
branch
from
a822826
to
112e33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the build is using system libraries (for bzip2, lua, ode, or
xdgbasedir), there's no need to add the corresponding subdirectories.
This reduces build time and avoids potential mix-ups.
Signed-off-by: Stephen Kitt steve@sk2.org