Add details to ManageHook.hs docs #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liskin
reviewed
Apr 27, 2024
src/XMonad/ManageHook.hs
Outdated
| @@ -91,7 +92,7 @@ className :: Query String | |||
| className = ask >>= (\w -> liftX $ withDisplay $ \d -> fmap resClass $ io $ getClassHint d w) | |||
|
|
|||
| -- | A query that can return an arbitrary X property of type 'String', | |||
| -- identified by name. | |||
| -- identified by name. Works for ASCII strings only. | |||
There was a problem hiding this comment.
Did you perhaps wish to add a note that for _NET_WM_NAME, WM_NAME and possibly also WM_CLASS there are special functions available that work better, and hyperlink to them?
There was a problem hiding this comment.
I’ve just added a short sentence referring to the specialized variants. Is that fine? Any more suggestions?
liskin
approved these changes
Apr 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add relevant information about
titleandstringPropertyas discussed in #503.Checklist
I've read CONTRIBUTING.md
I've confirmed these changes don't belong in xmonad-contrib instead
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: XXX
I updated the
CHANGES.mdfileWell, if you think, I shall test these doc changes or update the
CHANGES.md, please tell me.