Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve outbound_dropped_messages metric #391

Merged
merged 22 commits into from
Feb 27, 2024

Conversation

denopink
Copy link
Contributor

No description provided.

metrics.go Outdated Show resolved Hide resolved
workerPool.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 70.49180% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 59.90%. Comparing base (dca746e) to head (e5d8547).
Report is 13 commits behind head on main.

Files Patch % Lines
workerPool.go 44.26% 22 Missing and 12 partials ⚠️
eventDispatcher.go 73.91% 20 Missing and 10 partials ⚠️
metrics.go 78.51% 20 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   59.88%   59.90%   +0.02%     
==========================================
  Files          18       18              
  Lines        1558     1776     +218     
==========================================
+ Hits          933     1064     +131     
- Misses        611      671      +60     
- Partials       14       41      +27     
Flag Coverage Δ
unittests 59.90% <70.49%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink merged commit b6be11b into main Feb 27, 2024
16 checks passed
@denopink denopink deleted the denopink/feat/improve-outbound_dropped_messages-metric branch February 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants