Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a bascule helper package which uses functions from webpa-comm… #252

Merged
merged 6 commits into from
Apr 20, 2023

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Apr 18, 2023

What's included:

@maurafortino maurafortino self-assigned this Apr 18, 2023
@maurafortino maurafortino added this to In progress in XMiDT via automation Apr 18, 2023
@maurafortino maurafortino marked this pull request as draft April 18, 2023 14:43
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #252 (f56b27f) into main (027b17f) will increase coverage by 13.87%.
The diff coverage is 69.28%.

@@             Coverage Diff             @@
##             main     #252       +/-   ##
===========================================
+ Coverage   21.74%   35.62%   +13.87%     
===========================================
  Files           7        8        +1     
  Lines         699      946      +247     
===========================================
+ Hits          152      337      +185     
- Misses        545      607       +62     
  Partials        2        2               
Flag Coverage Δ
unittests 35.62% <69.28%> (+13.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)
basculehelper/basculeHelper.go 75.51% <75.51%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

basculehelper/basculeHelper.go Outdated Show resolved Hide resolved
basculehelper/basculeHelper.go Outdated Show resolved Hide resolved
primaryHandler.go Outdated Show resolved Hide resolved
@maurafortino maurafortino added the webpa-common archival/deprecation work related to the archival & deprecation of webpa-common label Apr 19, 2023
@maurafortino maurafortino marked this pull request as ready for review April 20, 2023 14:21
@renaz6
Copy link
Member

renaz6 commented Apr 20, 2023

You'll want to fix the linter issues that were detected by the Go Lint job. If it's something trivial (like length of a function), you can skip it by adding a comment like this:
// nolint:staticcheck where the staticcheck part is the name of the linter.

XMiDT automation moved this from In progress to PRs: Approved Apr 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

72.5% 72.5% Coverage
0.0% 0.0% Duplication

@maurafortino maurafortino merged commit 9b9089f into main Apr 20, 2023
18 of 19 checks passed
XMiDT automation moved this from PRs: Approved to Done Apr 20, 2023
@maurafortino maurafortino deleted the bascule-metrics-refactor branch April 20, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
XMiDT
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants