Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracing configs #247

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Update tracing configs #247

merged 6 commits into from
Apr 20, 2023

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Mar 13, 2023 •
edited

  • added options for parent-based tracing to align with candlelight changes Improve Tracing Configurations candlelight#104
  • Closes Update Tracing Configurations #243
  • Updated Candlelight version in go.mod (will do this in a separate release)
  • Updated WRP-Go version in go.mod
  • With the new decoder added in WRP-Go and used in Candlelight, a check was added in primary handler to make sure the wrp message hasn't been decoded yet before decoding it (decoding twice would cause an error)

@denopink denopink self-requested a review March 13, 2023 15:56
@renaz6 renaz6 requested a review from schmidtw March 13, 2023 16:23
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited

Codecov Report

Merging #247 (768ca33) into main (027b17f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   21.74%   21.71%   -0.04%     
==========================================
  Files           7        7              
  Lines         699      700       +1     
==========================================
  Hits          152      152              
- Misses        545      546       +1     
  Partials        2        2
Flag Coverage Δ
unittests 21.71% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
primaryHandler.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renaz6 renaz6 marked this pull request as draft March 13, 2023 17:25
@renaz6 renaz6 self-assigned this Apr 6, 2023
@renaz6 renaz6 marked this pull request as ready for review April 14, 2023 15:13
denopink
denopink approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@renaz6 renaz6 merged commit c387960 into main Apr 20, 2023
17 of 19 checks passed
@renaz6 renaz6 deleted the tracingConfigs branch April 20, 2023 17:47
@renaz6 renaz6 mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

@johnabass johnabass johnabass approved these changes

@schmidtw schmidtw Awaiting requested review from schmidtw

Assignees

@renaz6 renaz6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Tracing Configurations
3 participants
@renaz6 @denopink @johnabass